Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow session isolation for some of the models #496

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

yaroslav-ost
Copy link
Contributor

@yaroslav-ost yaroslav-ost commented Jan 7, 2025

resolves #495

Description

This PR addresses the feature of allowing running some of the models in isolated sessions with different session configurations like number/types of workers. Existing functionality is preserved and no breaking changes were introduced.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-glue next" section.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yaroslav-ost
Copy link
Contributor Author

Hi @moomindani,

Could you please review my PR once you have a chance?

Thanks!

@moomindani
Copy link
Collaborator

Thank you for your contribution. Here's couple of feedback.

  • Can you add an integration test?
  • Currently it's not that easy for users to understand how the new parameter behaves. (e.g. which config is applied on specific models) Can you explain the use case of the new meta parameter in README?
  • Can you rethink the option name? Meta sounds too generic.
  • For some reason the link is associated with unrelated PR, not with the correct one (Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows #435). Can you fix the description?

@yaroslav-ost
Copy link
Contributor Author

Hi @moomindani,

Thanks for reviewing it and sorry for the late response:

  1. An integration test was added to check the scenario when a particular model is running in separate sessions with different session configuration
  2. A description of the meta parameter, along with an example of its usage, has been added to the README.
  3. The meta parameter already existed, so I’ve retained its name to avoid breaking changes for existing users.
  4. The link in the PR description has been fixed.

Thanks again for your feedback!

@yaroslav-ost
Copy link
Contributor Author

Hi @moomindani ,

Could you please review once you have a chance?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow session isolation for some of the models
2 participants