refactor list and watch logic out #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxaws
force-pushed
the
use-endpointslice
branch
from
562df30 to
5e72cc5
Compare
pxaws
force-pushed
the
use-endpointslice
branch
from
5e72cc5 to
129034c
Compare
mxiamxia
reviewed
Feb 3, 2025
plugins/processors/awsapplicationsignals/internal/resolver/podwatcher.go
Show resolved
Hide resolved
mxiamxia
previously approved these changes
Feb 3, 2025
jefchien
reviewed
Feb 4, 2025
jefchien
approved these changes
Feb 4, 2025
sky333999
approved these changes
Feb 4, 2025
musa-asad
pushed a commit
that referenced
this pull request
Feb 5, 2025
Co-authored-by: Ping Xiang <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Describe the problem or feature in addition to a link to the issues.
Description of changes
How does this change address the problem?
Create separate files for:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint