Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(elasticache): initial impl of subnet group L2 construct #14404

Closed
wants to merge 7 commits into from
Closed

feat(elasticache): initial impl of subnet group L2 construct #14404

wants to merge 7 commits into from

Conversation

bweigel
Copy link
Contributor

@bweigel bweigel commented Apr 27, 2021

This is a first implementation for an L2 construct of AWS::ElastiCache::SubnetGroup.
I am also worḱing on AWS::ElastiCache::ParameterGroup (#14402) and AWS::ElastiCache::ReplicationGroup.
Will submit PRs for those later.

Ref. #8196

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 27, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-elasticache Related to Amazon ElastiCache label Apr 27, 2021
@bweigel bweigel mentioned this pull request Apr 27, 2021
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e34237b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@bweigel bweigel marked this pull request as ready for review April 27, 2021 22:05
@iliapolo iliapolo added effort/large Large work item – several weeks of effort effort/medium Medium work item – several days of effort p2 and removed effort/large Large work item – several weeks of effort labels May 5, 2021
@iliapolo
Copy link
Contributor

iliapolo commented May 5, 2021

Thanks so much for submitting this pull request. I am marking this pull request as p2, which means that we are unable to work on it immediately, but it's definitely still on our radar.

We use +1s to help prioritize our work, and are happy to revaluate this pull request based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@iliapolo iliapolo removed their assignment May 5, 2021
@rix0rrr rix0rrr added feature-request A feature should be added or improved. p1 and removed p2 effort/medium Medium work item – several days of effort @aws-cdk/aws-elasticache Related to Amazon ElastiCache labels Mar 4, 2022
@github-actions
Copy link

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@github-actions
Copy link

github-actions bot commented May 5, 2022

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@github-actions github-actions bot added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label May 5, 2022
@github-actions github-actions bot closed this May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bweigel @aws-cdk-automation @iliapolo @rix0rrr