chore(prlint): fail prlinter on codecov failures, with exemption label #32674
Conversation
| projectPackages: await this.codecovProjectPackagesAwsCdkSucceeded(sha), | ||
| }; | ||
|
|
||
| validationCollector.validateRuleSet({ |
There was a problem hiding this comment.
this will always fail at the start because the codecov reports take time to be generated. not sure how bad that is yet.
| @@ -24,6 +25,7 @@ enum Exemption { | |||
| CLI_INTEG_TESTED = 'pr-linter/cli-integ-tested', | |||
| REQUEST_CLARIFICATION = 'pr/reviewer-clarification-requested', | |||
| REQUEST_EXEMPTION = 'pr-linter/exemption-requested', | |||
| CODECOV = "pr-linter/exempt-codecov", | |||
There was a problem hiding this comment.
I think one exemption for all 4 codecovs should be fine for now...
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32674 +/- ##
=======================================
Coverage 81.38% 81.38%
=======================================
Files 222 222
Lines 13695 13695
Branches 2412 2412
=======================================
Hits 11145 11145
Misses 2271 2271
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Our current process for codecov statuses is that they block the merge of a PR if the are failing. This PR attempts to move this failure further forward in the PR process, so that the PRlinter fails and alerts the author. It also means that we can include an exemption label to merge a PR that we allow to be in breach of the codecov report. Currently, to do so we must change the branch protection rules.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license