Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(synthetics): add new runtime playwright 1_0 and python 4_1 #32694

Closed
wants to merge 1 commit into from

Conversation

liuxiax
Copy link

@liuxiax liuxiax commented Dec 30, 2024

Issue # (if applicable)

No issue

Reason for this change

There are two new runtimes that were published recently. syn-nodejs-playwright-1.0 and syn-python-selenium-4.1

Description of changes

Adding two new runtimes.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Against documentation and updating that the template deploys with the new runtime version.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 30, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 30, 2024 22:45
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 30, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@liuxiax liuxiax changed the title chore(synthetics): Add new runtime playwright 1_0 and python 4_1 chore(synthetics): add new runtime playwright 1_0 and python 4_1 Dec 30, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 30, 2024 22:51

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25608ed
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 30, 2024
@gracelu0
Copy link
Contributor

Hi @liuxiax , thanks for your contribution! It looks like we already have a PR in progress for these new runtimes here: #32245, so I will be closing this one to avoid duplicate work and would encourage you to help review the PR. Thanks!

@gracelu0 gracelu0 closed this Dec 30, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants