EC2 Instance requireImdsv2 fix

[dil-mocsy]

Issue # (if applicable)

Closes #32886

#32886

Reason for this change

Prevent EC2 replace when toggling IMDSv2 required to true.

Description of changes

What code changes did you make?

Pre-existing behavior is if a launchTemplate exists then it bails early.
I updated the warning to better explain what's going on.

I removed the creation of a new launchTemplate entirely.
Instead I'm using a pre-existing method to add the option to the metadata.

node.instance.addMetadata('Options', { HttpTokens: 'required' });

Unless there was a previous setting in the template (example json is made up):

    "Options": {
     "RandomOtherOption": "optional"
     "HttpEndpoint": "enabled"
    }

Then it merges them instead of dropping the previous possibly unrelated things using typescript ....

Describe any new or updated permissions being added

No new permissions.

Description of how you validated changes

I copied this part of the code to my stack and instead of this.warn I used console.log

    const cfnResource = node.instance as CfnResource;
    if(!cfnResource.cfnOptions.metadata?.['Options']) {
      node.instance.addMetadata('Options', { HttpTokens: 'required' });
    } else {
      const existingOptions = cfnResource.cfnOptions.metadata!['Options'];
      if(existingOptions.HttpTokens) {
        this.warn(node, `HttpTokens Metadata Option already set: ${existingOptions.HttpTokens}. Overwriting to 'required'`);
      }
      cfnResource.cfnOptions.metadata!['Options'] =
      {
        ...existingOptions,
        HttpTokens: 'required'
      };
    }

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.
❌ The first word of the pull request title should not be capitalized. If the title starts with a CDK construct, it should be in backticks "``".

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

[dil-mocsy]

It may be possible we also want "HttpEndpoint": "enabled" in the template.json

The launchTemplate based code didn't include this, so I skipped too.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 89e288b
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[dil-mocsy]

This is draft PR at the moment because I'm still testing.

[dil-mocsy]

Because of aws-cloudformation/cloudformation-coverage-roadmap#655 this PR will never work.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.