chore(toolkit): request response #32926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Jan 14, 2025
Comment on lines
+118
to
+120
| export function markTesting() { | ||
| TESTING = true; | ||
| } |
There was a problem hiding this comment.
assume this would still be necessary when we test
| motivation: string, | ||
| question: string, | ||
| ) { | ||
| await withCorkedLogging(async () => { |
There was a problem hiding this comment.
#32898 needs to be implemented before we can get rid of this, right?
| throw new ToolkitError(`${motivation}, but concurrency is greater than 1 so we are unable to get a confirmation from the user`); | ||
| } | ||
|
|
||
| const confirmed = await ioHost.requestResponse<any, boolean>(prompt(`${chalk.cyan(question)} (y/n)?`)); |
There was a problem hiding this comment.
not too sure what to do here. prompt currently is nothing and a build failure atm. should this be written in aws-cdk/lib/logging.ts?
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a helper method named
askUserConfirmationwhich usesioHost.requestResponse.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license