-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): prepare cli for programmatic toolkit #32953
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is momo's code. i have reviewed and approve pending integ tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32953 +/- ##
==========================================
+ Coverage 81.40% 81.48% +0.07%
==========================================
Files 223 226 +3
Lines 13727 13768 +41
Branches 2411 2416 +5
==========================================
+ Hits 11175 11219 +44
+ Misses 2274 2271 -3
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Mergifyio update |
✅ Branch has been successfully updated |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Comments on closed issues and PRs are hard for our team to see. |
This PR pulls out changes to
packages/aws-cdk
andpackages/@aws-cdk/cli-lib-alpha
from #32919By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license