Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentage #32954

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bdoyle0182
Copy link

Issue # (if applicable)

Closes #32905.

Reason for this change

The Aws Batch Managed Compute Environment L2 currently does not allow for CfnParameter / Tokens for numeric properties that perform validation at synth time. This is a common pattern in other L2's in AWS CDK to skip the validation checks if the property can support being a cloud formation parameter

Description of changes

I updated the validation methods in ManagedComputeEnvironment to skip if the property being validated is a token. Affected properties are spotBidPercentage, minVCpus, and maxVCpus. The logic keeps performing any of the checks if enough information in any of the properties are there to do the check at synth time.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added new unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 15, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2025 19:31
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jan 15, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@bdoyle0182 bdoyle0182 changed the title fix(aws-batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage Jan 15, 2025
@bdoyle0182 bdoyle0182 changed the title fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage feat(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage Jan 15, 2025
@bdoyle0182 bdoyle0182 changed the title feat(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage Jan 15, 2025
Brendan Doyle added 2 commits January 15, 2025 11:55
…alidation' of https://github.com/bdoyle0182/aws-cdk into bdoyle0182/fix-managed-compute-environment-token-skip-validation
@bdoyle0182
Copy link
Author

bdoyle0182 commented Jan 15, 2025

I don't have an account currently that I can easily deploy the integration test to to generate the snapshot files, but I've tested it up to the deploy if someone else with an environment from the cdk team can handle that part on my behalf.

edit: nvm, got an environment should be good to go

@bdoyle0182 bdoyle0182 changed the title fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentageManage fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentage Jan 15, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 15, 2025 22:15

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 15, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8cba242
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-batch: ManagedComputeEnvironment L2's cannot handle CfnParameters due to validations
2 participants