-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(batch): support cfn parameters for managed compute environment properties minvcpus, maxvcpus, and spotbidpercentage #32954
base: main
Are you sure you want to change the base?
Conversation
…allow CfnParameters
…oken-skip-validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…alidation' of https://github.com/bdoyle0182/aws-cdk into bdoyle0182/fix-managed-compute-environment-token-skip-validation
I don't have an account currently that I can easily deploy the integration test to to generate the snapshot files, but I've tested it up to the deploy if someone else with an environment from the cdk team can handle that part on my behalf. edit: nvm, got an environment should be good to go |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…oken-skip-validation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32905.
Reason for this change
The Aws Batch Managed Compute Environment L2 currently does not allow for CfnParameter / Tokens for numeric properties that perform validation at synth time. This is a common pattern in other L2's in AWS CDK to skip the validation checks if the property can support being a cloud formation parameter
Description of changes
I updated the validation methods in ManagedComputeEnvironment to skip if the property being validated is a token. Affected properties are spotBidPercentage, minVCpus, and maxVCpus. The logic keeps performing any of the checks if enough information in any of the properties are there to do the check at synth time.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added new unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license