chore(toolkit): synth action with tests #32971
Conversation
mrgrain
force-pushed
the
mrgrain/toolkit/synth-tests
branch
from
21a6818 to
c32914d
Compare
mrgrain
force-pushed
the
mrgrain/toolkit/synth-tests
branch
2 times, most recently
from
6d1ffbd to
9ebb093
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32971 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 226 226
Lines 13768 13768
Branches 2416 2416
=======================================
Hits 11219 11219
Misses 2271 2271
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mrgrain
force-pushed
the
mrgrain/toolkit/synth-tests
branch
4 times, most recently
from
270403f to
eaf5f8c
Compare
mrgrain
changed the title
| * | ||
| * @deprecated this should be grabbed from the cloud assembly itself | ||
| */ | ||
| readonly output?: string; | ||
| readonly outdir?: string; |
There was a problem hiding this comment.
We previously used a mix in names. This is aligning on outdir as the canonical short version of "Output Directory"
There was a problem hiding this comment.
interfaces moved to a public file
There was a problem hiding this comment.
interfaces moved from a private file
There was a problem hiding this comment.
types moved to a different file
There was a problem hiding this comment.
types moved here from another file
mrgrain
force-pushed
the
mrgrain/toolkit/synth-tests
branch
from
eaf5f8c to
3e1c437
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
Closes #32940
Description of changes
Define the API for the synth action. Includes DX improvements for some other APIs.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
These are the tests!
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license