test(toolkit): tests for destroy #32975
Conversation
| @@ -425,7 +425,7 @@ export class Toolkit extends CloudAssemblySourceBuilder implements AsyncDisposab | |||
|
|
|||
| await ioHost.notify(info('Stack ARN:')); | |||
|
|
|||
| await ioHost.notify(data(deployResult.stackArn)); | |||
| await ioHost.notify(info(deployResult.stackArn)); | |||
There was a problem hiding this comment.
data doesn't exist and i assume that info is the better thing to put here anyway
There was a problem hiding this comment.
I think I marked data was deprecated, so this seems alright.
| @@ -3,5 +3,5 @@ import * as path from 'path'; | |||
| export * from './test-io-host'; | |||
|
|
|||
| export function fixture(name: string, app = 'app.js'): string { | |||
| return path.normalize(path.join(__dirname, '..', 'fixtures', name, app)); | |||
| return path.normalize(path.join(__dirname, '..', '_fixtures', name, app)); | |||
There was a problem hiding this comment.
assume that you will need this in the origin branch and then this diff will go away
| })); | ||
| }); | ||
|
|
||
| test('destroy from app', async () => { |
There was a problem hiding this comment.
this test fails but the equivalent synth test fails also, so i didn't pay it too much attention yet.
There was a problem hiding this comment.
I'm guessing we need to mock some CFN calls here?
mrgrain
force-pushed
the
mrgrain/toolkit/synth-tests
branch
5 times, most recently
from
eaf5f8c to
3e1c437
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32975 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 225 225
Lines 13702 13702
Branches 2404 2404
=======================================
Hits 11160 11160
Misses 2267 2267
Partials 275 275
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tests for the destroy action
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license