Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-eks): adding takeOwnership option to HelmChart construct #32981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanseltime
Copy link

Issue # (if applicable)

Closes #..

Reason for this change

Fulfilling the linked issue, this adds the new functionality flag of --take-ownership of Helm v3.17.0 to the HelmChart
custom resource.

Description of changes

  • Adds a new TakeOwnership payload parameter to the KubectlHandler custom resource function
  • Uses that payload to add the --take-ownership flag in the helm call in the custom resource function
  • Adds takeOwnership as an optional property to the HelmChart Construct
  • All default parameters are set to false to keep backward compatibility

Describe any new or updated permissions being added

No new permissions should be needed for this change.

Description of how you validated changes

  1. Unit tests are added to verify the defaults and setting of takeOwnership in HelmChart
  2. Integration tests are updated to:
    1. Use a non-deprecated EKS cluster (1.31) and standard KubectlLayer
    2. Create a helm chart with take-ownership set to verify the functionality doesn't break
    3. TODO - Until This kubectl layer PR is accepted, we can't update snapshots since no layers have the newest version of helm.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 06:48
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title of the pull request should omit 'aws-' from the name of modified packages. Use 'eks' instead of 'aws-eks'.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3ecd6ad
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants