Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): include tsc paths in precompilation #32992

Closed
wants to merge 3 commits into from

Conversation

HaaLeo
Copy link

@HaaLeo HaaLeo commented Jan 17, 2025

Issue #20666 (if applicable)

Closes #20666 .

Reason for this change

Enable support for tsconfig.json's path option.

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 17, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 17, 2025 14:23
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Jan 17, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

@HaaLeo HaaLeo changed the title feat(aws-lambda-nodejs): Include tsc paths in precompilation feat(lambda-nodejs): Include tsc paths in precompilation Jan 17, 2025
@HaaLeo HaaLeo changed the title feat(lambda-nodejs): Include tsc paths in precompilation fix(lambda-nodejs): Include tsc paths in precompilation Jan 17, 2025
@HaaLeo HaaLeo changed the title fix(lambda-nodejs): Include tsc paths in precompilation fix(lambda-nodejs): include tsc paths in precompilation Jan 17, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bf8b5b8
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@HaaLeo
Copy link
Author

HaaLeo commented Jan 17, 2025

This approach does not work to pass tsconfig paths option to the build

@HaaLeo HaaLeo closed this Jan 17, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-lambda-nodejs: Precompilation excludes path aliases in tsc command
2 participants