Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TestVectors): Reuse single KeyVectors client across TestVectors, GHA uses ubuntu-22.04 #1577

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Jan 17, 2025

Issue #, if available:

Description of changes:

Reusing a single KeyVectors client results in significant performance improvements.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucasmcdonald3 lucasmcdonald3 changed the title chore: Re-use single KeyVectors client across TestVectors chore(TestVectors): Re-use single KeyVectors client across TestVectors Jan 17, 2025
Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@lucasmcdonald3 lucasmcdonald3 changed the title chore(TestVectors): Re-use single KeyVectors client across TestVectors chore(TestVectors): Reuse single KeyVectors client across TestVectors, GHA uses ubuntu-22.04 Jan 17, 2025
Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@lucasmcdonald3 lucasmcdonald3 marked this pull request as ready for review January 17, 2025 23:38
@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner January 17, 2025 23:38
Copy link

Detected changes to the release files or to the check-files action

Copy link

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link
Contributor

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speed, I am speed ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants