chore(GHA): Run Java CI testing for MPL Latest Release #1605
+151
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecorella
reviewed
Jan 30, 2025
josecorella
reviewed
Jan 30, 2025
| uses: ./.github/workflows/dafny-interop.yml | ||
| with: | ||
| mpl-dafny: ${{needs.getLatestReleaseMplVersion.outputs.version}} | ||
| mpl-commit: ${{needs.getMplDafnyVersion.outputs.dafnyVersion}} |
There was a problem hiding this comment.
this doesn't make sense, why for the mpl commit are we supplying the dafny version?
There was a problem hiding this comment.
Because the MPL version will be built with its own Dafny version, and we pick this up from the project properties file of the MPL.
There was a problem hiding this comment.
Look at the first input to dafny-interop.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a daily job to check that the HEAD of DB-ESDK is compatible with the latest release of the MPL (pulled from Maven).
An important part is that this should be independent of Daily CI / Push CI / Pull CI, because when the MPL is actually updated, we will see errors with testing the last release, and we don't want our current CI process to get affected because of this.
We also won't need to go through the pain of running the MCM step to run dafny-interop.yml manually for the latest released version of the MPL. This new workflow does it automatically, and the oncall just needs to verify that everything is green.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.