merge dev changes to mainline #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ishedName fix: variadic methods build errors
…ishedName Fix: Update logs with dir paths
This is to avoid brazil checkout error that seems to conflict with brazil's 'Config' file.
More tests need to be added in test directory. Instructions: cmake ../ -DCODE_COVERAGE=ON make -j ./credentials-fetcher-test cd CMakeFiles/credentials-fetcher-test.dir/test ls *.gcno gcov tester.cpp.gcno lcov --capture --directory . --output-file gtest_coverage.info --ignore-errors mismatch genhtml gtest_coverage.info --output-directory CODE_COVERAGE Logs: $ ./credentials-fetcher-test Running main() from /builddir/build/BUILD/googletest-release-1.11.0/googletest/src/gtest_main.cc [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from DaemonTest [ RUN ] DaemonTest.InvalidCharacterTest [ OK ] DaemonTest.InvalidCharacterTest (0 ms) [----------] 1 test from DaemonTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 1 test. $ genhtml gtest_coverage.info --output-directory CODE_COVERAGE Found 17 entries. Found common filename prefix "/usr/include/c++" Generating output. Processing file 11/bits/move.h lines=2 hit=0 functions=3 hit=0 Processing file /usr/include/gtest/internal/gtest-internal.h lines=19 hit=17 functions=8 hit=7 Processing file 11/bits/unique_ptr.h lines=18 hit=6 functions=13 hit=2 Processing file /home/ec2-user/credentials-fetcher/test/tester.cpp lines=2 hit=2 functions=4 hit=4 Processing file 11/tuple lines=14 hit=6 functions=20 hit=4 Processing file 11/bits/stl_iterator_base_funcs.h lines=5 hit=0 functions=4 hit=0 Processing file 11/bits/alloc_traits.h lines=2 hit=0 functions=1 hit=0 Processing file 11/bits/stl_iterator_base_types.h lines=2 hit=0 functions=2 hit=0 Processing file 11/bits/char_traits.h lines=12 hit=0 functions=3 hit=0 Processing file /usr/include/gtest/gtest.h lines=17 hit=6 functions=11 hit=3 Processing file 11/bits/basic_string.tcc lines=13 hit=0 functions=2 hit=0 Processing file 11/ext/new_allocator.h lines=3 hit=0 functions=3 hit=0 Processing file /usr/include/gtest/gtest-printers.h lines=30 hit=0 functions=16 hit=0 Processing file 11/bits/basic_string.h lines=11 hit=0 functions=3 hit=0 Processing file 11/ext/alloc_traits.h lines=2 hit=0 functions=1 hit=0 Processing file /usr/include/gtest/internal/gtest-port.h lines=1 hit=0 functions=1 hit=0 Processing file 11/ext/type_traits.h lines=2 hit=0 functions=2 hit=0 Overall coverage rate: lines......: 23.9% (37 of 155 lines) functions......: 20.6% (20 of 97 functions) $ ls CODE_COVERAGE/ 11 cmd_line gcov.css home index-sort-l.html ruby.png updown.png amber.png emerald.png glass.png index-sort-f.html index.html snow.png usr
…com/aws/credentials-fetcher into fixes_for_DNS_and_distinguishedName
User: srinianu PackageId: empty-brazil Version: 2024-12-03T10:33:28.068932853Z
fix ldapsearch command
Update task def to have 10 containers and decrease memory per container
Add stress test scripts
feat: Add API integration tests
Refactor sql-tests and cleanup after test execution
This reverts commit 51d06a1.
Add sample java app to access sql using krb auth
- Fixed env variable usage - Fixed api integration test file name in CmakeList
fix: typo in api/tests/CMakeLists.txt
…-enforce-rule Revert s3 bucket ownership enforce rule
as14692
approved these changes
Jan 15, 2025
muskanlalit18
approved these changes
Jan 15, 2025
smhmhmd
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enhancements
Security
Try ldapsearch on all the valid FQDNs instead of just one. #133
fix: improvements to credentials-fetcher codestyle #120
Authentication & Configuration
fix ldapsearch command #149
Bug Fixes
Core Functionality
Fix: Domainless option in opensource mode #131
fix: variadic methods build errors #144
Updates
.NET 8 Migration
Upgrade utf_16 project to use .NET 8 with NativeAot and remove runtime .NET dependency #151
Platform Support
build: Conditionally use dotnet-runtime-8/dotnet-sdk-8 on Fedora 41 #130
fix protobuf detection for modern protobuf #116
Testing & Automation
Introduced CDK automation for ECS deployment
Add CDK automation to run Credentials-fetcher in ECS #138
Added comprehensive integration tests:
Update CDK Integration tests #152
feat: Add API integration tests #155
Add stress test scripts #156
Add sample java app to access sql using krb auth #158
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.