Add more generic AVX feature detection as well as flags for if avx512… #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… intrinsics are available.
… can use the extensions anyways.
graebm
reviewed
Jul 14, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 83.30% 83.23% -0.08%
==========================================
Files 56 56
Lines 5803 5808 +5
==========================================
Hits 4834 4834
- Misses 969 974 +5 ☔ View full report in Codecov by Sentry. |
graebm
approved these changes
Jul 15, 2023
| if (HAVE_M_AVX512_FLAG) | ||
| # docs imply AVX512 brings in AVX2. And it will compile, but it will break at runtime on | ||
| # instructions such as _mm256_load_si256(). Leave it on. | ||
| set(AVX_CFLAGS "/arch:AVX512 /arch:AVX2") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… intrinsics are available.
Clean up some cmake checks for SIMD and export them so AVX512 intrinsics support can be exported to other common runtime modules.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.