Support IPv6 endpoint #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyMusatkin
approved these changes
Feb 4, 2025
include/aws/crt/dns.h
Outdated
| @@ -0,0 +1,17 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
probably want to put it into DnsUtils.h similar to existign StringUtils
There was a problem hiding this comment.
sure, will change the filename
include/aws/crt/dns.h
Outdated
| { | ||
| namespace Crt | ||
| { | ||
| namespace dns |
There was a problem hiding this comment.
All crt namespaces start with upper case
source/dns.cpp
Outdated
|
|
||
| } // namespace dns | ||
| } // namespace Crt | ||
| } // namespace Aws |
There was a problem hiding this comment.
nit: new line at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-cpp#3244
Description of changes:
Create cpp bindings
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.