correct sample rate in wave export #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the recording is downsampled the new sample rate must also be passed to encodeWAV so that the wave header includes the new/correct sample rate.
|
Please merge this one, i also have tested this and wasted time (re) fixing it. |
|
This is an important fix that should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the recording is downsampled the new sample rate must also be passed to encodeWAV so that the wave header includes the new/correct sample rate.
*Issue #22
Description of changes:
Extended the encodeWAV function with a argument "sampleRate", this sample rate is now written to the wave header (not using the global variable recordSampleRate anymore). And in the exportBuffer function I pass now the new samplerate to the encodeWAV function.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.