This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
feat: add custom awsCredentialManager option #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow optional `awsCredentialManager` passthough to `createRouter`, and otherwise default to the `DefaultAwsCredentialManager`
devonpaluso
changed the title
|
These changes look fine to me other than the Prettier failures, but I'm curious what kind of credential manager you're building? Are there opportunities to improve the default one to meet your needs? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow optional
awsCredentialManagerpassthough tocreateRouterandcreateAwsProtonServiceActionmethods.Issue #, if available:
Description of changes:
There was no option to provide a desired
AwsCredentialManager, as theDefaultAwsCredentialManagerwas used. This allows an optional credential manager instance to be passed through thecreateRouterandcreateAwsProtonServiceActionmethods to be used instead. This is optional and will default to theDefaultAwsCredentialManagerotherwise.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.