Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add screen view event after session start #67

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. add screen view event after session start

How did you test these changes?
added the test case testSessionTimeoutAfterReopenTheApp

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Feb 29, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane February 29, 2024 08:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (a828261) to head (c0efd26).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #67      +/-   ##
============================================
+ Coverage     87.26%   87.42%   +0.15%     
- Complexity      455      458       +3     
============================================
  Files            42       42              
  Lines          1665     1686      +21     
  Branches        152      152              
============================================
+ Hits           1453     1474      +21     
  Misses          135      135              
  Partials         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit f9d9e57 into main Mar 1, 2024
6 checks passed
@zxkane zxkane deleted the page_view_after_session_start branch March 1, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants