Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support init SDK with custom configuration #75

Merged
merged 14 commits into from
Mar 22, 2024
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. support init SDK with custom configuration
  2. support add global attribute in configuration
  3. compatible with amplifyconfiguration.json file

How did you test these changes?
added test case for support configure amplify multiple times.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Mar 19, 2024
@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 19, 2024 10:19
@zhu-xiaowei zhu-xiaowei marked this pull request as draft March 19, 2024 10:27
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.93%. Comparing base (eff7fe2) to head (979dfaf).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...aws/solution/clickstream/ClickstreamAnalytics.java 96.15% 2 Missing ⚠️
...aws/solution/clickstream/AWSClickstreamPlugin.java 97.43% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #75      +/-   ##
============================================
+ Coverage     86.70%   87.93%   +1.23%     
- Complexity      468      488      +20     
============================================
  Files            42       40       -2     
  Lines          1707     1716       +9     
  Branches        156      171      +15     
============================================
+ Hits           1480     1509      +29     
+ Misses          150      140      -10     
+ Partials         77       67      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review March 19, 2024 11:47
README.md Outdated Show resolved Hide resolved
@zxkane zxkane merged commit 4dbefaf into main Mar 22, 2024
6 checks passed
@zxkane zxkane deleted the feature-init-sdk branch March 22, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants