Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support item record #38

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat: support item record #38

merged 5 commits into from
Dec 12, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support adding items with custom attributes.

NOTE: This is a breaking change, only pipelines from version 1.1+ can handle items with custom attribute.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Oct 13, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane October 13, 2023 07:23
@zhu-xiaowei zhu-xiaowei marked this pull request as draft October 13, 2023 07:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (1708b75) 95.40% compared to head (7437e0f) 94.62%.

Files Patch % Lines
...am/Dependency/Clickstream/Event/EventChecker.swift 90.58% 21 Missing ⚠️
...am/Support/Extension/JsonObject+ToJsonString.swift 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   95.40%   94.62%   -0.78%     
==========================================
  Files          34       35       +1     
  Lines        1784     1916     +132     
==========================================
+ Hits         1702     1813     +111     
- Misses         82      103      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review November 30, 2023 08:18
@zxkane zxkane merged commit 87a0e7f into main Dec 12, 2023
4 checks passed
@zxkane zxkane deleted the feature_item branch December 12, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants