Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support enable and disable sdk #39

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: support enable and disable sdk #39

merged 1 commit into from
Oct 31, 2023

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. support enable and disable sdk

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei added the enhancement New feature or request label Oct 27, 2023
@zhu-xiaowei zhu-xiaowei requested a review from zxkane October 27, 2023 08:53
@zxkane zxkane merged commit 42b7d44 into main Oct 31, 2023
4 checks passed
@zxkane zxkane deleted the disable_sdk branch October 31, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxkane zxkane zxkane approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhu-xiaowei @zxkane