Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when user attribute is empty #71

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix: crash when user attribute is empty #71

merged 2 commits into from
Jun 27, 2024

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. fix crash when user attribute is empty

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane June 26, 2024 07:51
@zhu-xiaowei zhu-xiaowei self-assigned this Jun 26, 2024
@zhu-xiaowei zhu-xiaowei added the bug Something isn't working label Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (45a4ad4) to head (9b6d945).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   96.91%   96.85%   -0.06%     
==========================================
  Files          35       35              
  Lines        1685     1686       +1     
==========================================
  Hits         1633     1633              
- Misses         52       53       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhu-xiaowei zhu-xiaowei marked this pull request as draft June 26, 2024 10:15
@zhu-xiaowei zhu-xiaowei marked this pull request as ready for review June 26, 2024 14:38
@zxkane zxkane merged commit 6e7a814 into main Jun 27, 2024
6 checks passed
@zxkane zxkane deleted the fix-user-attributes branch June 27, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants