-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bedrock): add prompt chat templates #876
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aws-rafams
requested review from
krokoko,
MichaelWalker-git,
dineshSajwan and
alexa-perlov
January 6, 2025 13:05
One thing: by upgrading to the latest cdk version, some tests are failing since the latest available Python version is 3.13. Currently, most lambdas are using 3.12, including the CRs. We can add a cdk nag suppress for now and do the upgrade in a separate PR since it will require some testing |
The go packaging is an issue with CDK v2.174 (see here ). |
krokoko
previously approved these changes
Jan 6, 2025
…> ChatMessage.user()
krokoko
approved these changes
Jan 6, 2025
MichaelWalker-git
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872
Note: to be able to merge this PR, it requires a CDK version bump from 2.166.0 to 2.174.0
Sample usage:
AWS Console
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.