Skip to content

Commit

Permalink
[SageMaker] Make default region value be None, so AWS config takes pr…
Browse files Browse the repository at this point in the history
…ecedence (#1134)

*Issue #, if available:*

*Description of changes:*

* Our current default for region in SageMaker jobs will override users'
local configuration. By setting this to None by default we respect the
local config, while allowing users to specify a different region if
needed.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
thvasilo authored Jan 14, 2025
1 parent 6c0f81e commit 359eceb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions sagemaker/launch/common_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ def get_common_parser() -> argparse.ArgumentParser:
default=1,
help="number of instances")
common_args.add_argument("--region", type=str,
default="us-west-2",
help="Region")
default=None,
help="AWS region to launch jobs in. Default is None, "
"which will rely on you AWS configuration to determine the region.")
common_args.add_argument("--task-name", type=str,
default=None, help="User defined SageMaker task name")
common_args.add_argument("--sm-estimator-parameters", type=str,
Expand Down

0 comments on commit 359eceb

Please sign in to comment.