Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSProcessing] Replace colons in edge feature paths with underscores to ensure EFS compatibility. #1073

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

thvasilo
Copy link
Contributor

Issue #, if available:

Description of changes:

  • When copying data from S3 to HDFS or EFS we can't use paths that contain colons :. We have already fixed this for edge structures and labels, this fixes it for features as well.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thvasilo thvasilo added ready able to trigger the CI gsprocessing For issues and PRs related the the GSProcessing library 0.4 labels Oct 22, 2024
@thvasilo thvasilo added this to the 0.4 release milestone Oct 22, 2024
@thvasilo thvasilo requested a review from jalencato October 22, 2024 22:17
@thvasilo thvasilo self-assigned this Oct 22, 2024
Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the label as well?

@thvasilo
Copy link
Contributor Author

thvasilo commented Oct 23, 2024 via email

Copy link
Collaborator

@jalencato jalencato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thvasilo thvasilo merged commit ed0f698 into awslabs:main Oct 23, 2024
9 checks passed
@thvasilo thvasilo deleted the gsp-edge-feature-naming branch October 23, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4 gsprocessing For issues and PRs related the the GSProcessing library ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants