-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSProcessing] Remove poetry as a requirement for building images. #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel confused about what we want to do with the PR here. If we remove the poetry dependencies, it seems like we make everything more complicated. Any reason we want to do that here?
docs/source/cli/graph-construction/distributed/gsprocessing/distributed-processing-setup.rst
Show resolved
Hide resolved
The user story is this: As a user trying to build and push Docker images for GSProcessing, I would like to not have to modify my Python environment to do so. Currently, building the GSProcessing image requires Python 3.9 and having This PR removes the requirement of having Python 3.9 and poetry installed, users can build the image regardless of the version of Python they have, and don't have to worry about `poetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need to make sure the requirement.txt is latest
310c0e3
to
fd2b473
Compare
…wslabs#1076) *Issue #, if available:* *Description of changes:* * Previously, build the gsprocessing images required Python 3.9 and poetry to be installed, leading to user friction. * With this commit we instead include requirements on a per-version basis, and no longer build wheels using poetry but install from source for both `prod` and `test` image targets. * We maintain backwards compatibility if the exported requirements file is not available for a particular version. * Also move EMRS image to 7.3.0 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Issue #, if available:
Description of changes:
prod
andtest
image targets.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.