Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add bias to edge decoder #1125

Merged
merged 14 commits into from
Jan 10, 2025

Conversation

RonaldBXu
Copy link
Contributor

@RonaldBXu RonaldBXu commented Jan 3, 2025

Issue #, if available:
An extension of issue #335

Description of changes:
Adding bias to edge decoders.

Regression test results after my changes:

Dataset		Test Performance	Validation Performance	Total Time	Epoch Time/Seconds
OGB-MAG-NC	Acc: 0.4070		Acc: 0.4151		0:25:08		69.963
OGB-PROD-NC	Acc: 0.7254		Acc: 0.9137		0:46:33		108.104

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@RonaldBXu RonaldBXu changed the title [Draft] [Feature] Add bias to edge decoder [Feature] Add bias to edge decoder Jan 8, 2025
@RonaldBXu RonaldBXu marked this pull request as ready for review January 8, 2025 22:12
@RonaldBXu RonaldBXu self-assigned this Jan 8, 2025
@RonaldBXu RonaldBXu added the 0.4 label Jan 8, 2025
@RonaldBXu RonaldBXu requested a review from jalencato January 8, 2025 23:01
python/graphstorm/config/argument.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Outdated Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Outdated Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
@zhjwy9343
Copy link
Contributor

Could you also modify this rst file to add EdgeRegression in this section: https://github.com/awslabs/graphstorm/blob/main/docs/source/api/references/graphstorm.model.rst#decoder-layer?

@RonaldBXu
Copy link
Contributor Author

RonaldBXu commented Jan 10, 2025

@zhjwy9343 I think it's already there?

@zhjwy9343
Copy link
Contributor

@zhjwy9343 I think it's already there?

Do you mean the EdgeRegression class? According to this latest version doc: https://graphstorm.readthedocs.io/en/latest/api/references/graphstorm.model.html, it is not there.

@zhjwy9343 zhjwy9343 added the ready able to trigger the CI label Jan 10, 2025
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
tests/unit-tests/test_decoder.py Show resolved Hide resolved
Copy link
Contributor

@classicsong classicsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@classicsong classicsong merged commit 75ff9ef into awslabs:main Jan 10, 2025
8 checks passed
@RonaldBXu RonaldBXu deleted the add-bias-to-edge-decoder branch January 10, 2025 23:23
jalencato pushed a commit that referenced this pull request Jan 13, 2025
*Issue #, if available:*
An extension of issue #335 

*Description of changes:*
Adding bias to edge decoders.

Regression test results after my changes:
```
Dataset		Test Performance	Validation Performance	Total Time	Epoch Time/Seconds
OGB-MAG-NC	Acc: 0.4070		Acc: 0.4151		0:25:08		69.963
OGB-PROD-NC	Acc: 0.7254		Acc: 0.9137		0:46:33		108.104
```

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.4 ready able to trigger the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants