devex improvements + testing #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,8 +12,26 @@ export async function getFunctionFromTs(relativePath: string, shouldCircuitFunct | |||
| compilerOptions: { module: ts.ModuleKind.CommonJS } | |||
| }); | |||
| const script = new vm.Script(result.outputText); | |||
| const customRequire = (moduleName: string) => { | |||
| try { | |||
| if (moduleName === "@axiom-crypto/halo2-lib-js") { | |||
jonathanpwang
approved these changes
Dec 11, 2023
ytham
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-autogenerate halo2-lib-js docs
-allow constants to be passed to all halo2-lib functions
-make halo2-lib-js context global (to avoid passing around context)
-halo2-lib-js unit testing in CI (vk equivalence with rust for every function, and js constant -> CircuitValue auto conversion testing)
before merging, halo2-lib-js version should be updated and published
closes #17