pages build and deployment #31
Clippy (beta)
107 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 107 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.82.0-nightly (c1a6199e9 2024-07-24)
- cargo 1.82.0-nightly (5f6b9a922 2024-07-19)
- clippy 0.1.81 (c1a6199 2024-07-24)
Annotations
Check warning on line 146 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
accessing first element with `slice.get(0)`
warning: accessing first element with `slice.get(0)`
--> halo2_proofs/src/helpers.rs:146:40
|
146 | 4 + slice.len() * (4 + field_len * slice.get(0).map(|poly| poly.len()).unwrap_or(0))
| ^^^^^^^^^^^^ help: try: `slice.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
Check warning on line 86 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:86:9
|
86 | /// WITHOUT performing the expensive Montgomery reduction.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
86 | /// WITHOUT performing the expensive Montgomery reduction.
| ++
Check warning on line 84 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:84:9
|
84 | /// `PrimeField` implementation.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
84 | /// `PrimeField` implementation.
| ++
Check warning on line 66 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:66:9
|
66 | /// and checks that the element is less than the modulus.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
66 | /// and checks that the element is less than the modulus.
| ++
Check warning on line 64 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:64:9
|
64 | /// `PrimeField` implementation, and checks that the element is less than the modulus.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
64 | /// `PrimeField` implementation, and checks that the element is less than the modulus.
| ++
Check warning on line 41 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:41:9
|
41 | /// does not perform any checks
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
41 | /// does not perform any checks
| ++
Check warning on line 39 in halo2_proofs/src/helpers.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/helpers.rs:39:9
|
39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
39 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
| ++
Check warning on line 1317 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:1312:41
|
1312 | / ... &util::load_instance(
1313 | | ... n,
1314 | | ... row,
1315 | | ... &self.cs.instance_queries,
1316 | | ... &self.instance,
1317 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1312 ~ util::load_instance(
1313 + n,
1314 + row,
1315 + &self.cs.instance_queries,
1316 + &self.instance,
1317 ~ ),
|
Check warning on line 1311 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:1311:41
|
1311 | ... &util::load(n, row, &self.cs.advice_queries, advice),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 1310 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:1310:41
|
1310 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 905 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:900:41
|
900 | / ... &util::load_instance(
901 | | ... n,
902 | | ... row,
903 | | ... &self.cs.instance_queries,
904 | | ... &self.instance,
905 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
900 ~ util::load_instance(
901 + n,
902 + row,
903 + &self.cs.instance_queries,
904 + &self.instance,
905 ~ ),
|
Check warning on line 899 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:899:41
|
899 | ... &util::load(n, row, &self.cs.advice_queries, advice),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.advice_queries, advice)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 898 in halo2_proofs/src/dev.rs
github-actions / Clippy (beta)
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev.rs:898:41
|
898 | ... &util::load(n, row, &self.cs.fixed_queries, &self.fixed),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `util::load(n, row, &self.cs.fixed_queries, &self.fixed)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
Check warning on line 256 in halo2_proofs/src/poly.rs
github-actions / Clippy (beta)
this bound is already specified as the supertrait of `ExactSizeIterator`
warning: this bound is already specified as the supertrait of `ExactSizeIterator`
--> halo2_proofs/src/poly.rs:256:26
|
256 | inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
| ^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implied_bounds_in_impls
= note: `-W clippy::implied-bounds-in-impls` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::implied_bounds_in_impls)]`
help: try removing this bound
|
256 - inv_denoms: impl Iterator<Item = F> + ExactSizeIterator,
256 + inv_denoms: impl ExactSizeIterator<Item = F>,
|
Check warning on line 605 in halo2_proofs/src/poly/domain.rs
github-actions / Clippy (beta)
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> halo2_proofs/src/poly/domain.rs:605:28
|
605 | fn fft_inner(&self, a: &mut Vec<F>, omega: F, log_n: u32, inverse: bool) {
| ^^^^^^^^^^^ help: change this to: `&mut [F]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
Check warning on line 593 in halo2_proofs/src/poly/domain.rs
github-actions / Clippy (beta)
writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
--> halo2_proofs/src/poly/domain.rs:593:23
|
593 | fn ifft(&self, a: &mut Vec<F>, omega_inv: F, log_n: u32, divisor: F) {
| ^^^^^^^^^^^ help: change this to: `&mut [F]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `-W clippy::ptr-arg` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::ptr_arg)]`
Check warning on line 382 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:382:9
|
382 | /// does not perform any checks
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
382 | /// does not perform any checks
| ++
Check warning on line 380 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:380:9
|
380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
380 | /// Checks that field elements are less than modulus, and then checks that the point is on the curve.
| ++
Check warning on line 378 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:378:9
|
378 | /// `PrimeField` implementation, and checks that the element is less than the modulus.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
378 | /// `PrimeField` implementation, and checks that the element is less than the modulus.
| ++
Check warning on line 377 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:377:9
|
377 | /// Reads a field element in standard form, with endianness specified by the
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
377 | /// Reads a field element in standard form, with endianness specified by the
| ++
Check warning on line 360 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:360:9
|
360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials)
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
360 | /// Does so by first writing the verifying key and then serializing the rest of the data (in the form of field polynomials)
| ++
Check warning on line 359 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:359:9
|
359 | /// WITHOUT performing the expensive Montgomery reduction.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
359 | /// WITHOUT performing the expensive Montgomery reduction.
| ++
Check warning on line 358 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:358:9
|
358 | /// Writes a field element into raw bytes in its internal Montgomery representation,
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
358 | /// Writes a field element into raw bytes in its internal Montgomery representation,
| ++
Check warning on line 356 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:356:9
|
356 | /// `PrimeField` implementation.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
356 | /// `PrimeField` implementation.
| ++
Check warning on line 355 in halo2_proofs/src/plonk.rs
github-actions / Clippy (beta)
doc list item without indentation
warning: doc list item without indentation
--> halo2_proofs/src/plonk.rs:355:9
|
355 | /// Writes a field element in standard form, with endianness specified by the
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
355 | /// Writes a field element in standard form, with endianness specified by the
| ++