Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix href for login button to navigate to /loginPage.html #3274

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

akshay0611
Copy link
Contributor

πŸ› οΈ Fixes Issue

Fixes: #3273

πŸ‘¨β€πŸ’» Description

What does this PR do?

  • Resolves an issue where the "Login/Register" button on /tools/sip.html navigated to an incorrect path (/tools/loginPage.html), resulting in a 400 error.
  • Updated the href attribute in the navigation link to use an absolute path (/loginPage.html) to ensure proper navigation.
  • This fix enhances user experience by resolving the navigation issue.

πŸ“„ Type of Change

  • [βœ…] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (adds or updates related documentation)

πŸ“· Screenshots/GIFs (if any)

N/A

βœ… Checklist

  • I am a participant of GSSoC-ext.
  • [βœ…] I have followed the contribution guidelines of this project.
  • [βœ…] I have made this change from my own.
  • I have taken help from some online resources.
  • [βœ…] My code follows the style guidelines of this project.
  • [βœ…] I have performed a self-review of my own code.
  • I have added documentation to explain my changes.

Mandatory Tasks

  • [βœ…] Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

🀝 GSSoC Participation

  • This PR is submitted under the GSSoC program.
  • I have taken prior approval for this feature/fix.

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
finveda βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 15, 2024 2:34pm

Copy link

Thank you for submitting your chaotic pull request! πŸ™Œ We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸŽ‰ Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from FinVeda team will review it as soon as possible. We appreciate your support in making this project better

Copy link

netlify bot commented Nov 15, 2024

βœ… Deploy Preview for getfinveda ready!

Name Link
πŸ”¨ Latest commit 1a7a4b0
πŸ” Latest deploy log https://app.netlify.com/sites/getfinveda/deploys/67375bf353b3af0008531541
😎 Deploy Preview https://deploy-preview-3274--getfinveda.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 43
Accessibility: 63
Best Practices: 75
SEO: 73
PWA: 50
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayush-that ayush-that merged commit 8e7e543 into ayush-that:main Nov 16, 2024
9 checks passed
@ayush-that ayush-that added bug Something isn't working level1 gssoc-ext labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Login button redirects to incorrect page on /tools/sip.html
2 participants