Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes the querystring-based layer filter functionality, since it's not being used and isn't compatible with the intended caching strategy.
Notes
claudia-local-api
and the actual API Gateway proxy's request objects are different in the case of a request with no querystring--claudia-local-api
provides an empty object, but API Gateway setsreq.queryStringParameters
to null. This caused a crash on Lambda that wasn't happening locally. And yeah, any deviation from "just sitting there not getting in the way" is cause enough to rip this out.Testing Instructions
This removes some tests, since there was a whole test file for the layer filtering. Since the issue that prompted this only showed up on AWS, local testing only goes so far. It makes sense to push this to staging manually and confirm that the analysis tiles show up. Which can be accomplished by pulling down the
.env
andclaudia.json
from the Staging settings bucket like inscripts/infra
and running the Tilegarden deployment command (docker-compose -f docker-compose.yml -f docker-compose.test.yml run --rm --entrypoint yarn tilegarden deploy
).Connects #634 and #635