Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map IDs to Black Temple spell overrides. #44

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

heyitsbench
Copy link
Contributor

No description provided.

@heyitsbench
Copy link
Contributor Author

Maybe I misremember, but I have some memory that these spells didn't actually get their override applied unless the map ID was supplied.

@heyitsbench
Copy link
Contributor Author

Apparently there is mention of certain spells on live (namely Naj'entus's bubble burst spell) being affected by tuning despite being in the override list.

@heyitsbench
Copy link
Contributor Author

Yea the spells that are supposed to be exempt from tuning are doing upwards of ~30% of the damage that was observed on the PTR, as can be seen in these combat logs:
https://legacyplayers.chromiecraft.com/viewer/4254/base?history_state=11 - PTR
https://legacyplayers.chromiecraft.com/viewer/4322/base?history_state=6 - Live
Excluding the logs to include only the Tidal Burst spell shows overall damage taken being doubled between the two runs as well as individual casts doing more damage than, again, was observed prior to release.

CC: @Nyeriah @elthehablo

@Nyeriah Nyeriah merged commit b5d8a30 into azerothcore:master Oct 10, 2024
1 check failed
@elthehablo
Copy link
Contributor

Is this tested? To me the map ids never made a difference before. That's why I ask

@elthehablo
Copy link
Contributor

elthehablo commented Oct 10, 2024

I'll check the code later to see if this makes sense

@heyitsbench
Copy link
Contributor Author

Is this tested?

I certainly did not test it, I do not have this module cloned locally, but I don't see what else could have caused these spells to be exempt during PTR testing but not for the live release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants