Feature/mdr_take_out_garbage/state_machine_definition #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/mdr_take_out_garbage/state_machine_definition
|
@robertocaiwu Do you think this is ready to be merged? If not, could you please add |
…to feature/mdr_take_out_garbage/state_machine_definition
|
I added the states I considered were missing on the SM. It is ready to be merged now. |
alex-mitrevski
requested changes
Mar 13, 2019
...lanning/mdr_scenarios/mdr_robocup_tasks/mdr_take_out_garbage/config/take_out_garbage_sm.yaml
Outdated
Show resolved
Hide resolved
...lanning/mdr_scenarios/mdr_robocup_tasks/mdr_take_out_garbage/config/take_out_garbage_sm.yaml
Outdated
Show resolved
Hide resolved
...lanning/mdr_scenarios/mdr_robocup_tasks/mdr_take_out_garbage/config/take_out_garbage_sm.yaml
Outdated
Show resolved
Hide resolved
...lanning/mdr_scenarios/mdr_robocup_tasks/mdr_take_out_garbage/config/take_out_garbage_sm.yaml
Outdated
Show resolved
Hide resolved
|
I just merged #125, for Travis checks to pass, you need the latest changes. |
…to feature/mdr_take_out_garbage/state_machine_definition
alex-mitrevski
approved these changes
Mar 13, 2019
|
The build is failing because the python package is not properly configured, can you take a look? |
…to feature/mdr_take_out_garbage/state_machine_definition
…of github.com:robertocaiwu/mas_domestic_robotics into feature/mdr_take_out_garbage/state_machine_definition
|
I believe this is ready to be merged. |
robertocaiwu
deleted the
feature/mdr_take_out_garbage/state_machine_definition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new scenario for the "take out the garbage" task for the German Open. The pull request includes the state machine definition for the task. [See #110]
Note: The state machine is not completed yet. There are some packages that do not exist yet, and as such the arguments are left empty.
Corrections and suggestions are welcome.