Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make year a proportional derived unit of month #15

Open
wants to merge 3 commits into
base: release-candidate
Choose a base branch
from
Open

Make year a proportional derived unit of month #15

wants to merge 3 commits into from

Conversation

jvanecek
Copy link
Member

@jvanecek jvanecek commented Jun 2, 2023

No description provided.

@jvanecek jvanecek requested review from gcotelli and mtabacman June 2, 2023 20:20
@jvanecek jvanecek self-assigned this Jun 2, 2023
mtabacman
mtabacman requested changes Jun 2, 2023
View reviewed changes
Copy link
Member

@mtabacman mtabacman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a test to cover this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtabacman mtabacman mtabacman requested changes

@gcotelli gcotelli Awaiting requested review from gcotelli

Requested changes must be addressed to merge this pull request.

Assignees

@jvanecek jvanecek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvanecek @mtabacman