Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query loop in covenant evmulator #92

Open
KonradStaniec opened this issue Jan 12, 2025 · 0 comments · May be fixed by #96
Open

Fix query loop in covenant evmulator #92

KonradStaniec opened this issue Jan 12, 2025 · 0 comments · May be fixed by #96
Assignees
Labels
bug Something isn't working

Comments

@KonradStaniec
Copy link
Collaborator

Currently query loop of covenant emulator always retrieve only one batch of pending delegations: https://github.com/babylonlabs-io/covenant-emulator/blob/v0.11.2/covenant/covenant.go#L480

This means if amount pending delegations is > limit in dels, err := ce.cc.QueryPendingDelegations(limit) call, covenant fails to move forward to sign next delegations.

Example:
Currently there is 1000 pending delegations in the system, covnenat already signed first 100 and it has limit set to 100 . Unless amount of pending delegation start decreasing, covenant will fail to move past first 100 delegations.

Actions:

  • QueryPendingDelegations should return delegations which are not already signed and that expect covenant memver signature.
@KonradStaniec KonradStaniec added the bug Something isn't working label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants