chore: add pagination to queryDelegationsWithStatus #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o covenant, also added address to covenant key chain info
Lazar955
approved these changes
Jan 18, 2025
Comment on lines
+189
to
+198
| func (bc *BabylonController) QueryPendingDelegations(limit uint64, filter FilterFn) ([]*types.Delegation, error) { | ||
| return bc.queryDelegationsWithStatus(btcstakingtypes.BTCDelegationStatus_PENDING, limit, filter) | ||
| } | ||
|
|
||
| func (bc *BabylonController) QueryActiveDelegations(limit uint64) ([]*types.Delegation, error) { | ||
| return bc.queryDelegationsWithStatus(btcstakingtypes.BTCDelegationStatus_ACTIVE, limit) | ||
| return bc.queryDelegationsWithStatus(btcstakingtypes.BTCDelegationStatus_ACTIVE, limit, nil) | ||
| } | ||
|
|
||
| func (bc *BabylonController) QueryVerifiedDelegations(limit uint64) ([]*types.Delegation, error) { | ||
| return bc.queryDelegationsWithStatus(btcstakingtypes.BTCDelegationStatus_VERIFIED, limit) | ||
| return bc.queryDelegationsWithStatus(btcstakingtypes.BTCDelegationStatus_VERIFIED, limit, nil) |
There was a problem hiding this comment.
Feels like this can be one function QueryDelegations(limit uint64, status btcstakingtypes.BTCDelegationStatus, filter FilterFn)
Comment on lines
+375
to
+400
| // amtSatFirst := btcutil.Amount(100) | ||
| // amtSatSecond := btcutil.Amount(150) | ||
| // amtSatThird := btcutil.Amount(200) | ||
| // lastUnsanitizedDels := []*types.Delegation{ | ||
| // &types.Delegation{ | ||
| // ParamsVersion: pVersionWithCovenant, | ||
| // TotalSat: amtSatFirst, | ||
| // }, | ||
| // delNoCovenant, | ||
| // &types.Delegation{ | ||
| // ParamsVersion: pVersionWithCovenant, | ||
| // TotalSat: amtSatSecond, | ||
| // }, | ||
| // delNoCovenant, | ||
| // &types.Delegation{ | ||
| // ParamsVersion: pVersionWithCovenant, | ||
| // TotalSat: amtSatThird, | ||
| // }, | ||
| // } | ||
|
|
||
| // sanitizedDels, err := covenant.SanitizeDelegations(covKeyPair.PublicKey, paramsGet, lastUnsanitizedDels) | ||
| // require.NoError(t, err) | ||
| // require.Len(t, sanitizedDels, 3) | ||
| // require.Equal(t, amtSatFirst, sanitizedDels[0].TotalSat) | ||
| // require.Equal(t, amtSatSecond, sanitizedDels[1].TotalSat) | ||
| // require.Equal(t, amtSatThird, sanitizedDels[2].TotalSat) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query should loop by the max limit set in the config
delegationlimit, since the BTC delegations already signed and the ones in which the covenant pub key was not constructed with are being removed by sanitizeDelegationsCloses: #92