Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New web3btc Finality Provider #127

Merged
merged 4 commits into from
Aug 15, 2024
Merged

New web3btc Finality Provider #127

merged 4 commits into from
Aug 15, 2024

Conversation

dblinux
Copy link
Contributor

@dblinux dblinux commented Aug 9, 2024

New web3btc Finality Provider

Checklist

Caution

The loss of the (generated keys + mnemonic) makes the finality provider useless and unable to provide finality, which would lead to no transition to later phases of the Babylon network.

dblinux added 2 commits August 9, 2024 10:24
Create web3btc.json
Create web3btc.sig
Copy link
Collaborator

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@RafilxTenfen RafilxTenfen requested review from a team, vitsalis, filippos47 and RafilxTenfen and removed request for a team, vitsalis and filippos47 August 9, 2024 10:46
@RafilxTenfen
Copy link
Collaborator

Hey @dblinux, one thing that I did not noticed in the first time, the Github account approved to submit PR is defined as deblinux can you verify?

@dblinux
Copy link
Contributor Author

dblinux commented Aug 13, 2024

Hey @dblinux, one thing that I did not noticed in the first time, the Github account approved to submit PR is defined as deblinux can you verify?

Yes, dear sir.

@dblinux
Copy link
Contributor Author

dblinux commented Aug 14, 2024

Review it, No problem.

@RafilxTenfen
Copy link
Collaborator

@dblinux there is a problem, the account that is suppose to submit the PR should be @Deblinux not @dblinux
Please, verify how to proceed

@dblinux
Copy link
Contributor Author

dblinux commented Aug 14, 2024

@dblinux there is a problem, the account that is suppose to submit the PR should be @Deblinux not @dblinux Please, verify how to proceed

My github account is dblinux, and the associated email address is [email protected]. I have received the email.

Copy link
Contributor Author

@dblinux dblinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review it ,No problem

@dblinux
Copy link
Contributor Author

dblinux commented Aug 14, 2024 via email

@RafilxTenfen
Copy link
Collaborator

@dblinux I understood, but the github handle informed at the KYB state that the user that was going to submit the PR should be deblinux, please verify this!

@dblinux
Copy link
Contributor Author

dblinux commented Aug 14, 2024 via email

@RafilxTenfen
Copy link
Collaborator

RafilxTenfen commented Aug 14, 2024

Screenshot of KYB related information,

------------------ 原始邮件 ------------------ 发件人: "babylonlabs-io/networks" @.>; 发送时间: 2024年8月14日(星期三) 晚上7:38 @.>; @.@.>; 主题: Re: [babylonlabs-io/networks] New web3btc Finality Provider (PR #127) @dblinux I understood, but the github handle informed at the KYB state that the user that was going to submit the PR should be deblinux, please verify this! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

I did not understand this

@RafilxTenfen
Copy link
Collaborator

Hey @dblinux, it was fixed
Thanks for the patience!

@dblinux
Copy link
Contributor Author

dblinux commented Aug 15, 2024

Hey @dblinux, it was fixed Thanks for the patience!

Thank you very much. I have received kyb's information update email.

Copy link
Contributor Author

@dblinux dblinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reivew ,it is ok

Copy link
Collaborator

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@RafilxTenfen RafilxTenfen requested review from a team, vitsalis and filippos47 August 15, 2024 12:38
@vitsalis vitsalis merged commit c85e92b into babylonlabs-io:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants