Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pSTAKE Finality Provider #243

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Conversation

mkRuby009
Copy link
Contributor

@mkRuby009 mkRuby009 commented Aug 11, 2024

New pSTAKE Finality Provider

Checklist

Caution

The loss of the (generated keys + mnemonic) makes the finality provider
useless and unable to provide finality, which would lead to no transition to
later phases of the Babylon network.

@mkRuby009
Copy link
Contributor Author

@RafilxTenfen We have provided the same valid email we have used for bbn-testnet-4 and one we have used for KYB process. Please can you confirm if below warning for email is an issue or not?

./bbn-1/finality-providers/scripts/verify-valid-fp.sh pSTAKE
Verifying /home/manasi/all-repos/bbn-1-networks/bbn-1/finality-providers/scripts/../registry/pSTAKE.json
Finality Provider Moniker: pSTAKE
Finality Provider Security Contact: [email protected]
[email protected] is not a valid email. Check whether you passed a valid finality provider email.
Finality Provider Commission: 0.03
Finality Provider EOTS Public Key: fc8a5b9930c3383e94bd940890e93cfcf95b2571ad50df8063b7011f120b918a
Finality Provider Signature: 15185d0e57ded0006eeb4d3b0fcc5ac38acd266e7c01cec0f684ae4e9899089e5a8e6ebff0c66a2512d961486bbb09b843d8be5f73d591477e5af0ca5b23aefd
Verifying signature with eotsd...
Verification is successful!

@RafilxTenfen
Copy link
Collaborator

Hey @mkRuby009, this warning is incorrect
I will verify the email regex checker
I am still waiting for the KYB verification to start the review

@mkRuby009
Copy link
Contributor Author

Hey @mkRuby009, this warning is incorrect I will verify the email regex checker I am still waiting for the KYB verification to start the review

Hey @RafilxTenfen Thanks for the reply.
Our KYB verification doc has been reviewed. Please review this PR as possible.
Thanks.

@RafilxTenfen
Copy link
Collaborator

Thanks.
Still waiting for the KYB approval to review
@mkRuby009

@RafilxTenfen
Copy link
Collaborator

Hey @mkRuby009, the github account approved to submit the PR is https://github.com/persistenceOne
Which is a team, you are not a member of that team, can you verify?
image

@mkRuby009
Copy link
Contributor Author

mkRuby009 commented Aug 15, 2024

Hey @RafilxTenfen Perhaps, a profile visibility issue, I have made it public now. I am already member of this org: https://github.com/persistenceOne since 2 years.
Please re-check the link and kindly review our PR.
Thanks!
image

@RafilxTenfen
Copy link
Collaborator

@mkRuby009 Thanks!

Copy link
Collaborator

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@RafilxTenfen RafilxTenfen requested review from a team, vitsalis and filippos47 August 15, 2024 12:25
@vitsalis vitsalis merged commit 63110d6 into babylonlabs-io:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants