Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various workspaces - Root dependencies clean up #2405

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

awanlin
Copy link
Contributor

@awanlin awanlin commented Dec 25, 2024

Hey, I just made a Pull Request!

Root dependencies clean up based on my comments from #2025

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin
Copy link
Contributor Author

awanlin commented Jan 7, 2025

Thanks @deepan10 @04kash

@christoph-jerolimov @ciiay @Xantier, can you please give this a look?

@awanlin awanlin force-pushed the topic/root-dependencies-clean-up branch from b6275fc to a52515a Compare January 7, 2025 18:27
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping.

I've tested rbac (the incl. backstage app) and it works as expected.

Lgtm!

@awanlin awanlin enabled auto-merge (squash) January 13, 2025 14:58
@awanlin awanlin merged commit f8b7fab into backstage:main Jan 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants