Bacpop-211 - add Streptococcus pyogenes #58
Conversation
| assert project_data["status"]["microreact"] == "finished" | ||
| assert project_data["status"]["network"] == "finished" | ||
|
|
||
| def test_run_poppunk_streptococcus_pyogenes(client, qtbot): |
There was a problem hiding this comment.
rest of file is cleanup and extracting common code into functions
There was a problem hiding this comment.
Looks good, works for me. Could you refactor the integration tests to reduce repetition even more? They're each testing that poppunk goes through the same process - or almost the same? So could have a single function that checks for that, with maybe a couple of parameters for anything that needs to be different e.g. metadata csv file? Up to you though!
yup good idea cleanup up a lot more |
This adds new species Streptococcus pyogenes.
Testing:
For frontend ensure branch is
bacpop-186-v9-dbalso ensure api_branch is pointed tobacpop-211-pyogenes-dev... also you will have to re-run./scripts/download_databasesagain.Run the new sample ive slacked, selecting the Streptococcus pyogenes as the project species