Updated version number in Cargo.toml #245
jhellewell14Annotations
81 warnings
|
missing documentation for a method:
src/skalo/utils.rs#L278
warning: missing documentation for a method
--> src/skalo/utils.rs:278:5
|
278 | pub fn get_range(&self, start: usize, end: usize) -> Vec<u8> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a method:
src/skalo/utils.rs#L274
warning: missing documentation for a method
--> src/skalo/utils.rs:274:5
|
274 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a method:
src/skalo/utils.rs#L248
warning: missing documentation for a method
--> src/skalo/utils.rs:248:5
|
248 | pub fn decode(&self) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/skalo/utils.rs#L215
warning: missing documentation for an associated function
--> src/skalo/utils.rs:215:5
|
215 | pub fn encode(dna: &str) -> Self {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L210
warning: missing documentation for a struct field
--> src/skalo/utils.rs:210:5
|
210 | pub original_length: usize,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L209
warning: missing documentation for a struct field
--> src/skalo/utils.rs:209:5
|
209 | pub data: Vec<u8>,
| ^^^^^^^^^^^^^^^^^
|
|
missing documentation for an associated function:
src/skalo/utils.rs#L194
warning: missing documentation for an associated function
--> src/skalo/utils.rs:194:5
|
194 | / pub fn new(
195 | | sequence: DnaSequence,
196 | | vec_snps: Vec<usize>,
197 | | ) -> Self {
| |_____________^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L190
warning: missing documentation for a struct field
--> src/skalo/utils.rs:190:5
|
190 | pub vec_snps: Vec<usize>,
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L189
warning: missing documentation for a struct field
--> src/skalo/utils.rs:189:5
|
189 | pub sequence: DnaSequence,
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L188
warning: missing documentation for a struct
--> src/skalo/utils.rs:188:1
|
188 | pub struct VariantInfo {
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L173
warning: missing documentation for a function
--> src/skalo/utils.rs:173:1
|
173 | pub fn get_last_nucl(encoded_kmer: u128) -> char {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L155
warning: missing documentation for a function
--> src/skalo/utils.rs:155:1
|
155 | pub fn decode_kmer(encoded: u128, k: usize) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L140
warning: missing documentation for a function
--> src/skalo/utils.rs:140:1
|
140 | pub fn encode_u8_kmer(dna: &[u8]) -> u128 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L116
warning: missing documentation for a function
--> src/skalo/utils.rs:116:1
|
116 | pub fn encode_kmer(kmer: &str) -> u128 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L88
warning: missing documentation for a function
--> src/skalo/utils.rs:88:1
|
88 | pub fn rev_compl_u128(kmer: u128, k: usize) -> u128 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/utils.rs#L69
warning: missing documentation for a function
--> src/skalo/utils.rs:69:1
|
69 | pub fn rev_compl(seq: &str) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a static:
src/skalo/utils.rs#L26
warning: missing documentation for a static
--> src/skalo/utils.rs:26:1
|
26 | pub static DATA_INFO: OnceLock<DataInfo> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L24
warning: missing documentation for a struct field
--> src/skalo/utils.rs:24:5
|
24 | pub sample_names: Vec<String>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L23
warning: missing documentation for a struct field
--> src/skalo/utils.rs:23:5
|
23 | pub k_graph: usize,
| ^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L22
warning: missing documentation for a struct
--> src/skalo/utils.rs:22:1
|
22 | pub struct DataInfo {
| ^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a static:
src/skalo/utils.rs#L17
warning: missing documentation for a static
--> src/skalo/utils.rs:17:1
|
17 | pub static CONFIG: OnceLock<Config> = OnceLock::new();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L15
warning: missing documentation for a struct field
--> src/skalo/utils.rs:15:5
|
15 | pub reference_genome: Option<PathBuf>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L14
warning: missing documentation for a struct field
--> src/skalo/utils.rs:14:5
|
14 | pub nb_threads: usize,
| ^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L13
warning: missing documentation for a struct field
--> src/skalo/utils.rs:13:5
|
13 | pub max_indel_kmers: usize,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L12
warning: missing documentation for a struct field
--> src/skalo/utils.rs:12:5
|
12 | pub max_depth: usize,
| ^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L11
warning: missing documentation for a struct field
--> src/skalo/utils.rs:11:5
|
11 | pub max_missing: f32,
| ^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L10
warning: missing documentation for a struct field
--> src/skalo/utils.rs:10:5
|
10 | pub output_name: String,
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct field:
src/skalo/utils.rs#L9
warning: missing documentation for a struct field
--> src/skalo/utils.rs:9:5
|
9 | pub input_file: String,
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/utils.rs#L8
warning: missing documentation for a struct
--> src/skalo/utils.rs:8:1
|
8 | pub struct Config {
| ^^^^^^^^^^^^^^^^^
|
|
missing documentation for a struct:
src/skalo/read_graph.rs#L299
warning: missing documentation for a struct
--> src/skalo/read_graph.rs:299:1
|
299 | pub struct PathState {
| ^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/read_graph.rs#L19
warning: missing documentation for a function
--> src/skalo/read_graph.rs:19:1
|
19 | / pub fn build_variant_groups(
20 | | mut all_kmers: HashMap<u128, Vec<u128>>,
21 | | start_kmers: HashSet<u128>,
22 | | end_kmers: HashSet<u128>,
23 | | kmer_2_samples: HashMap<u128, BitSet>,
24 | | ) {
| |_^
|
|
missing documentation for a function:
src/skalo/input.rs#L17
warning: missing documentation for a function
--> src/skalo/input.rs:17:1
|
17 | pub fn read_input_file() -> (usize, Vec<String>, KmerGraph, KmerSamples) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/extremities.rs#L66
warning: missing documentation for a function
--> src/skalo/extremities.rs:66:1
|
66 | pub fn combine_kmers(encoded_kmer1: u128, encoded_kmer2: u128) -> u128 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a function:
src/skalo/extremities.rs#L7
warning: missing documentation for a function
--> src/skalo/extremities.rs:7:1
|
7 | / pub fn identify_good_kmers(
8 | | all_kmers: &HashMap<u128, Vec<u128>>,
9 | | kmer_2_samples: &HashMap<u128, BitSet>,
10 | | ) -> (HashSet<u128>, HashSet<u128>) {
| |___________________________________^
|
|
missing documentation for a module:
src/skalo/mod.rs#L8
warning: missing documentation for a module
--> src/skalo/mod.rs:8:1
|
8 | pub mod utils;
| ^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L7
warning: missing documentation for a module
--> src/skalo/mod.rs:7:1
|
7 | pub mod read_graph;
| ^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L3
warning: missing documentation for a module
--> src/skalo/mod.rs:3:1
|
3 | pub mod input;
| ^^^^^^^^^^^^^
|
|
missing documentation for a module:
src/skalo/mod.rs#L2
warning: missing documentation for a module
--> src/skalo/mod.rs:2:1
|
2 | pub mod extremities;
| ^^^^^^^^^^^^^^^^^^^
|
|
missing documentation for a variant:
src/cli.rs#L361
warning: missing documentation for a variant
--> src/cli.rs:361:5
|
361 | Indel {
| ^^^^^
|
|
missing documentation for a module:
src/lib.rs#L434
warning: missing documentation for a module
--> src/lib.rs:434:1
|
434 | pub mod skalo;
| ^^^^^^^^^^^^^
|
note: the lint level is defined here
--> src/lib.rs:406:9
|
406 | #![warn(missing_docs)]
| ^^^^^^^^^^^^
|
|
struct `DnaSequence` has a public `len` method, but no `is_empty` method:
src/skalo/utils.rs#L274
warning: struct `DnaSequence` has a public `len` method, but no `is_empty` method
--> src/skalo/utils.rs:274:5
|
274 | pub fn len(&self) -> usize {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `#[warn(clippy::len_without_is_empty)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
src/merge_ska_array.rs#L628
warning: the following explicit lifetimes could be elided: 'a
--> src/merge_ska_array.rs:628:6
|
628 | impl<'a, IntT> Iterator for KmerIter<'a, IntT>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
628 - impl<'a, IntT> Iterator for KmerIter<'a, IntT>
628 + impl<IntT> Iterator for KmerIter<'_, IntT>
|
|
|
empty line after doc comment:
src/ska_ref.rs#L110
warning: empty line after doc comment
--> src/ska_ref.rs:110:5
|
110 | / /// Mapping information
111 | |
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
111 | ///
|
|
|
empty line after doc comment:
src/ska_ref.rs#L101
warning: empty line after doc comment
--> src/ska_ref.rs:101:5
|
101 | / /// Input sequence
102 | |
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
= note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
= help: if the empty line is unintentional remove it
help: if the documentation should include the empty line include it in the comment
|
102 | ///
|
|
|
the following explicit lifetimes could be elided: 'a:
src/ska_ref/idx_check.rs#L50
warning: the following explicit lifetimes could be elided: 'a
--> src/ska_ref/idx_check.rs:50:6
|
50 | impl<'a> Iterator for IdxCheckIter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
50 - impl<'a> Iterator for IdxCheckIter<'a> {
50 + impl Iterator for IdxCheckIter<'_> {
|
|
|
the following explicit lifetimes could be elided: 'a:
src/ska_dict/bit_encoding.rs#L185
warning: the following explicit lifetimes could be elided: 'a
--> src/ska_dict/bit_encoding.rs:185:6
|
185 | impl<'a> UInt<'a> for u128 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
185 - impl<'a> UInt<'a> for u128 {
185 + impl UInt<'_> for u128 {
|
|
|
the following explicit lifetimes could be elided: 'a:
src/ska_dict/bit_encoding.rs#L127
warning: the following explicit lifetimes could be elided: 'a
--> src/ska_dict/bit_encoding.rs:127:6
|
127 | impl<'a> UInt<'a> for u64 {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
127 - impl<'a> UInt<'a> for u64 {
127 + impl UInt<'_> for u64 {
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
| |____________________________________^ help: consider parenthesizing your expression: `(1 << (key & 63)) | (1 << ((key >> 6) & 63))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63) | (1 << ((key >> 12) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63) | (1 << ((key >> 18) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bloom_filter.rs#L63
warning: operator precedence can trip the unwary
--> src/ska_dict/bloom_filter.rs:63:9
|
63 | / 1 << (key & 63)
64 | | | 1 << ((key >> 6) & 63)
65 | | | 1 << ((key >> 12) & 63)
66 | | | 1 << ((key >> 18) & 63)
67 | | | 1 << ((key >> 24) & 63)
| |_____________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
help: consider parenthesizing your expression
|
63 ~ 1 << (key & 63)
64 + | 1 << ((key >> 6) & 63)
65 + | 1 << ((key >> 12) & 63)
66 + | 1 << ((key >> 18) & 63) | (1 << ((key >> 24) & 63))
|
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L200
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:200:17
|
200 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 64) & 0x0000000000000000FFFFFFFFFFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L200
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:200:16
|
200 | self = (self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF)
| ________________^
201 | | | (self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 64 & 0x0000000000000000FFFFFFFFFFFFFFFF) | ((self & 0x0000000000000000FFFFFFFFFFFFFFFF) << 64)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L198
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:198:17
|
198 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L198
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:198:16
|
198 | self = (self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF)
| ________________^
199 | | | (self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L196
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:196:17
|
196 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L196
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:196:16
|
196 | self = (self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF)
| ________________^
197 | | | (self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16;
| |_______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L194
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:194:17
|
194 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L194
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:194:16
|
194 | self = (self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF)
| ________________^
195 | | | (self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L192
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:192:17
|
192 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L192
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:192:16
|
192 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F)
| ________________^
193 | | | (self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L190
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:190:17
|
190 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x33333333333333333333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L190
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:190:16
|
190 | self = (self >> 2 & 0x33333333333333333333333333333333)
| ________________^
191 | | | (self & 0x33333333333333333333333333333333) << 2;
| |______________________________________________________________^ help: consider parenthesizing your expression: `(self >> 2 & 0x33333333333333333333333333333333) | ((self & 0x33333333333333333333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L136
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:136:17
|
136 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32) & 0x00000000FFFFFFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L136
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:136:16
|
136 | self = (self >> 32 & 0x00000000FFFFFFFF) | (self & 0x00000000FFFFFFFF) << 32;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 32 & 0x00000000FFFFFFFF) | ((self & 0x00000000FFFFFFFF) << 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L135
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:135:17
|
135 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16) & 0x0000FFFF0000FFFF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L135
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:135:16
|
135 | self = (self >> 16 & 0x0000FFFF0000FFFF) | (self & 0x0000FFFF0000FFFF) << 16;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 16 & 0x0000FFFF0000FFFF) | ((self & 0x0000FFFF0000FFFF) << 16)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L134
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:134:17
|
134 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8) & 0x00FF00FF00FF00FF`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L134
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:134:16
|
134 | self = (self >> 8 & 0x00FF00FF00FF00FF) | (self & 0x00FF00FF00FF00FF) << 8;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 8 & 0x00FF00FF00FF00FF) | ((self & 0x00FF00FF00FF00FF) << 8)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L133
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:133:17
|
133 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4) & 0x0F0F0F0F0F0F0F0F`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L133
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:133:16
|
133 | self = (self >> 4 & 0x0F0F0F0F0F0F0F0F) | (self & 0x0F0F0F0F0F0F0F0F) << 4;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 4 & 0x0F0F0F0F0F0F0F0F) | ((self & 0x0F0F0F0F0F0F0F0F) << 4)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L132
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:132:17
|
132 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2) & 0x3333333333333333`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/bit_encoding.rs#L132
warning: operator precedence can trip the unwary
--> src/ska_dict/bit_encoding.rs:132:16
|
132 | self = (self >> 2 & 0x3333333333333333) | (self & 0x3333333333333333) << 2;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(self >> 2 & 0x3333333333333333) | ((self & 0x3333333333333333) << 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L210
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:210:34
|
210 | self.rc_upper = (self.rc_upper >> 2
| __________________________________^
211 | | | (IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))
| |______________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_upper >> 2) | ((IntT::from_encoded_base(rc_base(new_base))) << (2 * ((half_k * 2) - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L206
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:206:34
|
206 | self.rc_lower = (self.rc_lower >> 2
| __________________________________^
207 | | | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1))))
| |____________________________________________________________________________________________^ help: consider parenthesizing your expression: `(self.rc_lower >> 2) | ((IntT::from_encoded_base(self.rc_middle_base)) << (2 * (half_k - 1)))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
|
|
operator precedence can trip the unwary:
src/ska_dict/split_kmer.rs#L199
warning: operator precedence can trip the unwary
--> src/ska_dict/split_kmer.rs:199:27
|
199 | self.upper = (self.upper << 2
| ___________________________^
200 | | | (IntT::from_encoded_base(self.middle_base) << (half_k * 2)))
| |_____________________________________________________________________________^ help: consider parenthesizing your expression: `(self.upper << 2) | (IntT::from_encoded_base(self.middle_base) << (half_k * 2))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
= note: `#[warn(clippy::precedence)]` on by default
|
|
clippy_check
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy_check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|