Creating a test for max_reads #222
Annotations
7 warnings
assigning the result of `Clone::clone()` may be inefficient:
src/ska_ref.rs#L314
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/ska_ref.rs:314:9
|
314 | self.mapped_names = ska_dict.names().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.mapped_names.clone_from(ska_dict.names())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
this function has too many arguments (8/7):
src/merge_ska_dict.rs#L258
warning: this function has too many arguments (8/7)
--> src/merge_ska_dict.rs:258:1
|
258 | / fn parallel_append<IntT>(
259 | | depth: usize,
260 | | offset: usize,
261 | | file_list: &[InputFastx],
... |
266 | | max_reads: Option<usize>,
267 | | ) -> MergeSkaDict<IntT>
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
|
assigning the result of `Clone::clone()` may be inefficient:
src/merge_ska_dict.rs#L85
warning: assigning the result of `Clone::clone()` may be inefficient
--> src/merge_ska_dict.rs:85:9
|
85 | self.names[other.idx()] = other.name().clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.names[other.idx()].clone_from(other.name())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
the item `ParallelIterator` is imported redundantly:
src/merge_ska_array.rs#L28
warning: the item `ParallelIterator` is imported redundantly
--> src/merge_ska_array.rs:28:5
|
25 | use ndarray::parallel::prelude::*;
| ----------------------------- the item `ParallelIterator` is already imported here
...
28 | use rayon::iter::ParallelIterator;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
Rust project - latest (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust project - latest (stable)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust project - latest (nightly)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|