Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link & reference to the sandbox.bio tutorial. #88

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

vrbouza
Copy link
Collaborator

@vrbouza vrbouza commented Jan 21, 2025

No description provided.

@vrbouza vrbouza added the documentation Improvements or additions to documentation label Jan 21, 2025
@vrbouza vrbouza requested a review from johnlees January 21, 2025 11:01
@vrbouza vrbouza self-assigned this Jan 21, 2025
@johnlees
Copy link
Member

We can bump the version here to pass that check/so we don't forget

Can we also try removing -Zprofile from https://github.com/bacpop/ska.rust/blob/master/.github/workflows/codecov.yml and see if the codecov starts running again?

@vrbouza
Copy link
Collaborator Author

vrbouza commented Jan 21, 2025

It doesn't work because it needs the coverage. I have found a way of fixing it, following mozilla/grcov#1240 & https://github.com/mozilla/grcov?tab=readme-ov-file#example-how-to-generate-source-based-coverage-for-a-rust-project , I'll try to implement it & commit it

@vrbouza vrbouza force-pushed the master branch 2 times, most recently from 278f3a0 to f77033a Compare January 22, 2025 13:45
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.15%. Comparing base (d66b021) to head (90e07bc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   93.10%   96.15%   +3.04%     
==========================================
  Files          16       16              
  Lines        2263     2754     +491     
==========================================
+ Hits         2107     2648     +541     
+ Misses        156      106      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrbouza vrbouza added the bug Something isn't working label Jan 22, 2025
@vrbouza vrbouza force-pushed the master branch 4 times, most recently from 24b0dee to 22d1c73 Compare January 22, 2025 14:01
@vrbouza
Copy link
Collaborator Author

vrbouza commented Jan 22, 2025

I have changed the workflow and now it seems that it works, but for that I had to modify env. variables, move the rust version to stable, and remove some steps. I kinda followed what is said here: mozilla/grcov#1240 (comment) .

There are three more checks that are "expected" for a while already, I don't know if my changes affected them also :/ ...

@jhellewell14
Copy link
Collaborator

Thanks for looking at this @vrbouza. The checks are still expected so I am not sure if they will ever finish?

@johnlees
Copy link
Member

Let's merge and see what happens

@johnlees johnlees merged commit d12a09f into bacpop:master Jan 23, 2025
4 checks passed
@johnlees
Copy link
Member

Yeah, seems like it all worked, thanks both!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants