-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added link & reference to the sandbox.bio tutorial. #88
Conversation
We can bump the version here to pass that check/so we don't forget Can we also try removing |
It doesn't work because it needs the coverage. I have found a way of fixing it, following mozilla/grcov#1240 & https://github.com/mozilla/grcov?tab=readme-ov-file#example-how-to-generate-source-based-coverage-for-a-rust-project , I'll try to implement it & commit it |
278f3a0
to
f77033a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 93.10% 96.15% +3.04%
==========================================
Files 16 16
Lines 2263 2754 +491
==========================================
+ Hits 2107 2648 +541
+ Misses 156 106 -50 ☔ View full report in Codecov by Sentry. |
24b0dee
to
22d1c73
Compare
I have changed the workflow and now it seems that it works, but for that I had to modify env. variables, move the rust version to stable, and remove some steps. I kinda followed what is said here: mozilla/grcov#1240 (comment) . There are three more checks that are "expected" for a while already, I don't know if my changes affected them also :/ ... |
Thanks for looking at this @vrbouza. The checks are still expected so I am not sure if they will ever finish? |
Let's merge and see what happens |
Yeah, seems like it all worked, thanks both!! |
No description provided.