Skip to content

Moved rest of skalo code into ska, using Indel command runs the code …

Sign in for the full log view
GitHub Actions / clippy succeeded Jan 14, 2025 in 1s

clippy

75 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 75
Note 0
Help 0

Versions

  • rustc 1.86.0-nightly (48a426eca 2025-01-12)
  • cargo 1.86.0-nightly (088d49608 2025-01-10)
  • clippy 0.1.86 (48a426eca9 2025-01-12)

Annotations

Check warning on line 12 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> src/skalo_read_graph.rs:6:1
   |
6  | / pub fn build_sequences<'a>(
7  | |     len_kmer: usize,
8  | |     all_kmers: &HashMap<u128, HashMap<u128, u32>>,
9  | |     start_kmers: &HashSet<u128>,
10 | |     end_kmers: &HashSet<u128>,
11 | |     index_map: &'a HashMap<u32, String>,
12 | | ) -> HashMap<String, Vec<VariantInfo<'a>>> {
   | |__________________________________________^

Check warning on line 200 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> src/skalo_utils.rs:192:1
    |
192 | / pub fn filter_output_sequences(
193 | |     variant_groups: HashMap<String, Vec<VariantInfo>>,
194 | |     len_kmer: usize,
195 | |     all_samples: Vec<String>,
...   |
199 | |     input_name: &str,
200 | | ) {
    | |_^

Check warning on line 136 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> src/skalo_utils.rs:132:1
    |
132 | / pub fn identify_good_kmers(
133 | |     len_kmer: usize,
134 | |     all_kmers: &HashMap<u128, HashMap<u128, u32>>,
135 | |     index_map: &HashMap<u32, String>,
136 | | ) -> (HashSet<u128>, HashSet<u128>) {
    | |___________________________________^

Check warning on line 119 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for an associated function

warning: missing documentation for an associated function
   --> src/skalo_utils.rs:111:5
    |
111 | /     pub fn new(
112 | |         //entry_kmer: u128,
113 | |         //exit_kmer: u128,
114 | |         sequence: String,
...   |
118 | |         maj_samples: HashSet<&'a str>,
119 | |     ) -> Self {
    | |_____________^

Check warning on line 107 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
   --> src/skalo_utils.rs:107:5
    |
107 |     pub maj_samples: HashSet<&'a str>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 106 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
   --> src/skalo_utils.rs:106:5
    |
106 |     pub count_samples: HashMap<&'a str, i32>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 105 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
   --> src/skalo_utils.rs:105:5
    |
105 |     pub visited_nodes: HashSet<u128>,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 104 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
   --> src/skalo_utils.rs:104:5
    |
104 |     pub is_snp: bool,
    |     ^^^^^^^^^^^^^^^^

Check warning on line 103 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a struct field

warning: missing documentation for a struct field
   --> src/skalo_utils.rs:103:5
    |
103 |     pub sequence: String,
    |     ^^^^^^^^^^^^^^^^^^^^

Check warning on line 84 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> src/skalo_utils.rs:84:1
   |
84 | pub fn get_last_nucleotide(encoded_kmer: u128) -> char {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 68 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> src/skalo_utils.rs:68:1
   |
68 | pub fn decode_kmer(encoded: u128, k: usize) -> String {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 45 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> src/skalo_utils.rs:45:1
   |
45 | pub fn encode_kmer(kmer: &str) -> u128 {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 18 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
  --> src/skalo_utils.rs:18:1
   |
18 | pub fn rev_compl_u128(kmer: u128, k: usize) -> u128 {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 5 in src/skalo_utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
 --> src/skalo_utils.rs:5:1
  |
5 | pub fn rev_compl(seq: &str) -> String {
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 437 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
   --> src/lib.rs:437:1
    |
437 | pub mod skalo_read_graph;
    | ^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 434 in src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a module

warning: missing documentation for a module
   --> src/lib.rs:434:1
    |
434 | pub mod skalo_utils;
    | ^^^^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> src/lib.rs:406:9
    |
406 | #![warn(missing_docs)]
    |         ^^^^^^^^^^^^

Check warning on line 234 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`f32` -> `f32`)

warning: casting to the same type is unnecessary (`f32` -> `f32`)
   --> src/skalo_read_graph.rs:234:22
    |
234 |     let union_size = (set1.len() as f32 + set2.len() as f32 - intersection_size) as f32;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(set1.len() as f32 + set2.len() as f32 - intersection_size)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 132 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/skalo_read_graph.rs:132:56
    |
132 | ...                   majrule_samples.insert(&sample);
    |                                              ^^^^^^^ help: change this to: `sample`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 109 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
   --> src/skalo_read_graph.rs:109:37
    |
109 |                     previous_kmer = good_next[0].clone();
    |                                     ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `good_next[0]`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 90 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:90:48
   |
90 | ...                   good_next.push(kmer2.clone());
   |                                      ^^^^^^^^^^^^^ help: try removing the `clone` call: `kmer2`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 87 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:87:48
   |
87 | ...                   good_next.push(kmer2.clone());
   |                                      ^^^^^^^^^^^^^ help: try removing the `clone` call: `kmer2`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 70 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:70:48
   |
70 | ...                   kmer2_to_test.push(kmer2.clone());
   |                                          ^^^^^^^^^^^^^ help: try dereferencing it: `*kmer2`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 54 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:54:43
   |
54 |             let mut previous_kmer: u128 = next_kmer.clone();
   |                                           ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*next_kmer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 52 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:52:28
   |
52 |             visited.insert(next_kmer.clone());
   |                            ^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*next_kmer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 51 in src/skalo_read_graph.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `u128` which implements the `Copy` trait

warning: using `clone` on type `u128` which implements the `Copy` trait
  --> src/skalo_read_graph.rs:51:28
   |
51 |             visited.insert(kmer.clone());
   |                            ^^^^^^^^^^^^ help: try dereferencing it: `*kmer`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy