Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quick-run.js #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update quick-run.js #31

wants to merge 1 commit into from

Conversation

kentcdodds
Copy link
Contributor

Remove the multiple candidates check.

@kentcdodds
Copy link
Contributor Author

Ref: #28

@bahmutov
Copy link
Owner

bahmutov commented Nov 5, 2017

Wait, if there are several candidates we silently just the first one? That does not seem good.

@kentcdodds
Copy link
Contributor Author

That's what I meant by my issue. And it wouldn't be silent. It'll tell you which one it's executing right?

@bahmutov
Copy link
Owner

bahmutov commented Nov 5, 2017

I don't like it. You might want to execute "deploy:stage" but because "deploy:prod" comes before it alphabetically suddenly you kick it off. I would be for printing choices slightly better (like it does right not if you pass unknown command) Something like this for nr dep

Multiple candidates found ...
- deploy:stage: node script.js --env stage
- deploy:prod: node script.js --env prod

@kentcdodds
Copy link
Contributor Author

It'd be cool if it'd give me an interactive selection option so I could choose which I want rather than just quitting them 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentcdodds @bahmutov