Improve OSS config validation (#150)

baijunyao · Jun 24, 2020 · bcea1d5 · bcea1d5
1 parent 2549ef5
commit bcea1d5
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/app/Http/Requests/Config/Update.php b/app/Http/Requests/Config/Update.php
@@ -40,6 +40,19 @@ public function withValidator($validator)
             if ($this->has('204') && !in_array('public', $this->input('204'))) {
                 $validator->errors()->add('204', __('Local drive must be checked'));
             }
+
+            if ($this->has('204') && in_array('oss_uploads', $this->input('204')) && !$this->isJson()) {
+                foreach ([
+                    200 => 'AccessKeyID',
+                    201 => 'AccessKeySecret',
+                    202 => 'BUCKET',
+                    203 => 'ENDPOINT',
+                ] as $id => $description) {
+                    if ($this->input($id, '') === '') {
+                        $validator->errors()->add($id, $description . ': ' . __('The content can not be empty'));
+                    }
+                }
+            }
         });
     }
 }