Limit the amount of input we read into memory in arduino sketches. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a pushback mechanism to not read faster from a serial bridge than how fast the stack, or a CAN-bus output can sink packets. This is especially important for USBSerial inputs, which can supply data as fast as we are willing to read it. The implementation relies on two mechanisms: - setting the gridconnect converter to keep track of the CAN frames and only let a fixed number of them (5) exist at any time in the CAN hub. - adding a notifiable to the SerialBridge that keep track of the last txt buffer we sent to the gridconnect bridge. We do not read more bytes from the serial port in the read loop until the previous buffer is processed by the gridconnect parser.
atanisoft
approved these changes
Nov 12, 2023
atanisoft
reviewed
Nov 12, 2023
balazsracz
added a commit
that referenced
this pull request
Dec 3, 2023
* master: Ensures that 'make clean' empties lib directory of symlinks. (#753) Add an input/output GPIO type. This helps support bit banged I2C. (#752) Adds TinyUsb based CDC virtual Com port driver with an STM32 port. (#748) Limit the amount of input we read into memory in arduino sketches. (#746) Updates to send_datagram cmdline utility (#740)
balazsracz
added a commit
that referenced
this pull request
Dec 3, 2023
* bracz-lib-clean: Ensures that 'make clean' empties lib directory of symlinks. (#753) Add an input/output GPIO type. This helps support bit banged I2C. (#752) Adds TinyUsb based CDC virtual Com port driver with an STM32 port. (#748) Limit the amount of input we read into memory in arduino sketches. (#746) Updates to send_datagram cmdline utility (#740)
balazsracz
added a commit
that referenced
this pull request
Dec 23, 2023
…t-hub-router * 'master' of github.com:bakerstu/openmrn: (152 commits) Switches over make tests at toplevel to use the tests target instead of the cov target. Ensures that openmrn and application directory builds can run in parallel. (#754) Ensures that 'make clean' empties lib directory of symlinks. (#753) Add an input/output GPIO type. This helps support bit banged I2C. (#752) Adds TinyUsb based CDC virtual Com port driver with an STM32 port. (#748) Limit the amount of input we read into memory in arduino sketches. (#746) Updates to send_datagram cmdline utility (#740) Adds lflash command to the bracz-railcom board support makefile. Do not crash on an incoming message with 0 alias. (#751) Add common app test coverage rules. (#750) Fix symlinking of library files to the lib directory. (#747) Refactors the SPIFFS flash driver for the F7 into a generic stm32 flash driver. (#742) Unaligned read/write support in TivaEEPROM storage (#741) Adds support for producer/consumer identified message in the CallbackEventHandler. (#743) Improve error handling in BroadcastTimeDefs::string_to_date() (#745) Fix test makefiles and test target (#736) Moves the bootloader hook so that the hook implementation gets a chance to look at incoming frames. Fixes missing includes. Fixes missing symbol error. Adds stm32f072 HAL drivers to bare.armv6m compilation target. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pushback mechanism to not read faster from a serial bridge than how fast the stack, or a CAN-bus output can sink packets. This is especially important for USBSerial inputs, which can supply data as fast as we are willing to read it.
The implementation relies on two mechanisms: